Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Avoid inferring model type #336

Closed
wants to merge 1 commit into from
Closed

FIX Avoid inferring model type #336

wants to merge 1 commit into from

Conversation

chillu
Copy link
Member

@chillu chillu commented Jul 7, 2021 •
edited
Loading

Since Versioned->versions() results in an ArrayList, it triggers database queries.
The database isn't always available when the schema is built (e.g. on deployment and CI environments).

Relies on: silverstripe/silverstripe-graphql#395
Context: silverstripe/silverstripe-graphql#388

Tasks

  • Fix setting of resolvedModelClass

@chillu chillu mentioned this pull request Jul 7, 2021
Open
17 tasks
@chillu
FIX Avoid inferring model type
70e702a 
Since Versioned->versions() results in an ArrayList, it triggers database queries.
The database isn't always available when the schema is built (e.g. on deployment and CI environments).
Context: silverstripe/silverstripe-graphql#388
@GuySartorelli
Copy link
Member

Since this is an old draft, and I haven't seen instances of this being a problem in my time maintaining Silverstripe CMS, I'm going to close this.

If someone can show me a recent case where this has been a problem, we can look into opening an issue and taking it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillu @GuySartorelli